Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event part in storybook fixed #2345

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

tshimber
Copy link
Contributor

@tshimber tshimber commented Aug 30, 2024

Fixes #2315
camelCase to kebab-case event naming info added

PS I've checked, it works as kebab-case for Angular and Vue, also for React both with .addEventListener and with wrappers.

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 8718fac
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/66d1cae5260dc800084bb6e1
😎 Deploy Preview https://deploy-preview-2345--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amir-ba amir-ba self-requested a review September 19, 2024 08:49
Copy link
Collaborator

@amir-ba amir-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amir-ba amir-ba merged commit 8681ed8 into telekom:main Sep 19, 2024
12 checks passed
amir-ba added a commit that referenced this pull request Sep 19, 2024
* ci: sets up docker compose alias for compatibility (#2342)

* fix: dropdown scroll fixed (#2333)

* chip accessibility fix (#2332)

* feat: chip keyboard handling fixed

* feat: chip html added

* fix: snapshot updated

* fix: focus issues fixed

* fix: readme fix

* checkbox and switch css fixes for high contrast mode (#2317)

fix: checkbox and switch CSS fixes for high contrast mode

* ghost btn in storybook  (#2341)

* fix: ghost btn in storybook fixed

* fix: one more ghost fixed

* event part in storybook fixed (#2345)

* fix: event part in storybook fixed

* fix: german versions fixed

* aria details vs aria describedby fixed for text field (#2352)

* refactor: aria details vs aria describedby fixed for text field

* fix: reverted to ariaDetailedId + description added to storybook

* chore(release): publish (#2354)

* chore(release): publish

---------

Co-authored-by: tshimber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ScaleNotification] Events in Angular
2 participants