forked from facebookarchive/skybison
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specialize binary ops for floats #484
Draft
tekknolagi
wants to merge
6
commits into
trunk
Choose a base branch
from
mb-specialize-bin-float
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tekknolagi
commented
May 14, 2023
- Add BINARY_{ADD,SUB,MUL,POWER}_FLOAT specializations in interpreter
- Add asm interpreter implementation of DUP_TOP_TWO
- Add asm interpreter implementation of ROT_THREE
- Add INPLACE_{ADD,SUB}_FLOAT specializations in interpreter
- Add asm interpreter implementation of BINARY_MUL_FLOAT
- Add the other ops; they are very similar
This is hot in nbody
This is hot in nbody
TODO: add tests
This is hot in nbody
{
"django_minimal_requests": {
"benchmark": "django_minimal_requests",
"cg_instructions before": 703648,
"cg_instructions now": 703440,
"cg_instructions ∆": "-0.0%",
"interpreter_args": [],
"interpreter_name": "pyro",
"version before": "42d68454344d08f625a7eb579a8f47a536da81ee",
"version now": "1df60d7c3b77ef93012bae8ddb265bdee34d8e92"
}
}
|
Summary
Benchmark detailsBase vs. New
CPython vs New
Base
New
CPython
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.