Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging in without setting a position #202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions pgoapi/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ class ServerBusyOrOfflineException(Exception):
class PleaseInstallProtobufVersion3(Exception):
pass

class NoPlayerPositionSetException(Exception):
pass

class EmptySubrequestChainException(Exception):
pass

Expand All @@ -48,4 +45,4 @@ class ServerSideAccessForbiddenException(Exception):
pass

class UnexpectedResponseException(Exception):
pass
pass
4 changes: 2 additions & 2 deletions pgoapi/pgoapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
from pgoapi.rpc_api import RpcApi
from pgoapi.auth_ptc import AuthPtc
from pgoapi.auth_google import AuthGoogle
from pgoapi.exceptions import AuthException, NotLoggedInException, ServerBusyOrOfflineException, NoPlayerPositionSetException, EmptySubrequestChainException
from pgoapi.exceptions import AuthException, NotLoggedInException, ServerBusyOrOfflineException, EmptySubrequestChainException

from . import protos
from POGOProtos.Networking.Requests_pb2 import RequestType
Expand Down Expand Up @@ -168,7 +168,7 @@ def call(self):
raise EmptySubrequestChainException()

if (self._position_lat is None) or (self._position_lng is None) or (self._position_alt is None):
raise NoPlayerPositionSetException()
self.log.info('No player position set')

if self._auth_provider is None or not self._auth_provider.is_login():
self.log.info('Not logged in')
Expand Down