feat: remove examples from packaging

[shyim]

saves 2MB in everyones vendor folder :)

[CLAassistant]

All committers have signed the CLA.

[williamdes]

Well, that will not help me at Debian packaging, but I will manage to workaround it
Thanks !

[shyim]

composer package as debian package? 😱

[williamdes]

composer package as debian package? scream

Well, no. But in a sense yes.
Let me explain, the file you just changed controls the command git archive. GitHub uses that to give you nice tarballs on branches and tags/releases.

The tarballs are re-used by packagist/composer. And also packaging people in Debian or other distributions.
See: https://salsa.debian.org/phpmyadmin-team/tcpdf
See: https://salsa.debian.org/phpmyadmin-team/tcpdf/-/blob/debian/6.6.2+dfsg1-1_bpo11+1/debian/watch (the file used by Debian watch )

So if you exclude tests or other files from the git archive, other users who need them will have to use git clone to have them back. It's not very cool but sometimes it's best for everyone to have them excluded from the git archive.
Because at Debian the tests will be run on the source code to ensure the packaged code really works: https://salsa.debian.org/phpmyadmin-team/tcpdf/-/blob/debian/6.6.2+dfsg1-1_bpo11+1/debian/tests/control

Does that help understand ?

[shyim]

Ahhh okay. Thanks for maintaining phpmyadmin on debian! ❤️

[williamdes]

Ahhh okay. Thanks for maintaining phpmyadmin on debian! ❤️

And more of them ;p
I wrote an article right now: https://blog.williamdes.eu/Debian/the-debian-packages-i-maintain/

[williamdes]

What do you think about this one @nicolaasuni ?
Also, if you accept this, can you GPG sign your tags so I can securely import them into Debian ?

[nicolaasuni]

@williamdes I will look into sign the tags.

[nicolaasuni]

@williamdes Is this something worth doing or shall we focus on the new tc-lib-pdf lib instead?

[williamdes]

@williamdes Is this something worth doing or shall we focus on the new tc-lib-pdf lib instead?

Removing the examples will save quite some bytes on each server that downloads tcpdf.
Merging this would be great.

Thank you for looking into git tags and commits signing.

I would argue that we could also drop https://github.com/tecnickcom/TCPDF/blob/main/tcpdf_import.php and https://github.com/tecnickcom/TCPDF/blob/main/tcpdf_parser.php
Conversation about this on #574 and #577 (duplicate)

[williamdes]

@nicolaasuni what do you think about this PR and my last message ?