[ADD/#16] Button / 컴포넌트 구현 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into add/#16-button-component
boiledEgg-s
approved these changes
Jul 9, 2024
Comment on lines
+43
to
+45
| val interactionSource = remember { MutableInteractionSource() } | ||
| val isPressed by interactionSource.collectIsPressedAsState() | ||
| val backgroundColor = if (isPressed) TerningMain2 else TerningMain |
There was a problem hiding this comment.
버튼 색상 변경 방법 신기하네요!!
InteractionSource를 알아보다가 말았는데 여기서 배우고 갑니다!!
Hyobeen-Park
approved these changes
Jul 9, 2024
Comment on lines
+43
to
+45
| val interactionSource = remember { MutableInteractionSource() } | ||
| val isPressed by interactionSource.collectIsPressedAsState() | ||
| val backgroundColor = if (isPressed) TerningMain2 else TerningMain |
| @@ -33,7 +33,7 @@ fun ProvideTerningTypography(typography: TerningTypography, content: @Composable | |||
| } | |||
|
|
|||
| @Composable | |||
| fun TerningTheme( | |||
| fun TerningPointTheme( | |||
| val isPressed by interactionSource.collectIsPressedAsState() | ||
| val backgroundColor = if (isPressed) TerningMain2 else TerningMain | ||
|
|
||
| CompositionLocalProvider(LocalRippleTheme provides NoRippleTheme) { |
There was a problem hiding this comment.
궁금한거 있습니다!!! 이렇게 선언만 해두면 바로 ripple이 사라지는건가요??????
There was a problem hiding this comment.
네! 기존에 있던 LocalRippleTheme을 NoRippleTheme으로 바꿔준 겁니당
arinming
approved these changes
Jul 9, 2024
| ) { | ||
| Column( | ||
| modifier = Modifier | ||
| .fillMaxSize(), | ||
| .wrapContentHeight() // Modifier 변경 |
Comment on lines
+13
to
+18
| override fun rippleAlpha(): RippleAlpha = RippleAlpha( | ||
| draggedAlpha = 0.0f, | ||
| focusedAlpha = 0.0f, | ||
| hoveredAlpha = 0.0f, | ||
| pressedAlpha = 0.0f | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
core > designsystem패키징 수정 & 프리뷰 라이브러리 추가📸 Screenshot
1️⃣RectangleButton
2️⃣RoundButton
📢 To Reviewers
TerningTheme->TerningPointTheme으로 바꿨어요!타이포 사용할 땐 그대로
TerningTheme으로 접근하시면 됩니당