-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refresh token rotation configuration & github and facebook providers #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davenewza
changed the title
Feat/configurable rotation
feat: refresh token rotation configuration & github and facebook providers
Nov 14, 2023
jonbretman
reviewed
Nov 14, 2023
jonbretman
reviewed
Nov 14, 2023
jonbretman
reviewed
Nov 14, 2023
jonbretman
reviewed
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facebook
andgitlab
as built-in OpenID Connect providersNo need to provide issuer, token or auth URLs for Facebook and GitLab. They only need to be specified like this in the config:
Refresh Token Rotation configureable
For some clients it may be important to disable refresh token rotation. When rotation is disabled, the original refresh token will be returned when minting a new access token. This can be done in the config as follows:
Other changes