fix: id token verification performs client id check #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
ke-1240-move-auth-config-to-keelconfig
to
main
November 13, 2023 14:58
| verificationErrs = errors.Join(err, verificationErrs) | ||
| } else { | ||
| span.AddEvent("ID Token verified") | ||
| return idToken, nil |
There was a problem hiding this comment.
Does this need to verify all the providers?
There was a problem hiding this comment.
It's only testing against the providers which have the same issuer as the ID token:
providers, err := authConfig.GetOidcProvidersByIssuer(issuer)
louisaspicer
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client ID verification for ID token verification
An ID token will always have the OIDC server's client ID in the
subclaim, and it is important that the ID token verification steps include checking the client ID. Otherwise it's possible that the ID token was obtained from another application and wasn't intended for this app.Supports providers with the same issuer URL
It's possible for customers to configure multiple clients from the same issuer, so this PR also supports that now.