fix: model api fields filterable by null if they are not nullable fields #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WhereConditions should still be nullable for fields which are optional, because we'd still want the option to query by null for them. |
davenewza
approved these changes
Aug 25, 2023
adaam2
changed the title
davenewza
force-pushed
the
fix/where-conditions
branch
from
6e8d979 to
69204b7
Compare
davenewza
changed the title
louisaspicer
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
WhereConditions in the ModelAPI should only allow the
nullcomparison on a field if that field is defined as nullable