fix: allowing secrets and password types

teamkeel · Oct 29, 2023 · f97cc88 · f97cc88
1 parent 6fa0fad
commit f97cc88
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 40 deletions.
diff --git a/schema/completions/__debug_bin4018105356 b/schema/completions/__debug_bin4018105356
diff --git a/schema/completions/completions.go b/schema/completions/completions.go
@@ -1191,9 +1191,6 @@ func getFieldNamesAtPath(asts []*parser.AST, model *parser.ModelNode, idents []s
 func getModelFieldCompletions(model *parser.ModelNode) []*CompletionItem {
 	completions := []*CompletionItem{}
 	for _, field := range query.ModelFields(model) {
-		if field.Type.Value == parser.FieldTypeSecret || field.Type.Value == parser.FieldTypePassword {
-			continue
-		}
 		completions = append(completions, &CompletionItem{
 			Label:       field.Name.Value,
 			Description: field.Type.Value,

diff --git a/schema/completions/completions_test.go b/schema/completions/completions_test.go
@@ -155,25 +155,6 @@ func TestCompositeUniqueCompletions(t *testing.T) {
 			`,
 			expected: []string{"subTitle", "title", "date"},
 		},
-		{
-			name: "available-fields-badly-formed-schema",
-			schema: `
-			model A {
-	
-				oops 
-
-				fields {
-					title Text
-					subTitle Text
-					date Date
-					timestamp Timestamp
-				}
-				@unique([<Cursor>
-
-					
-			`,
-			expected: []string{"subTitle", "title", "date"},
-		},
 		{
 			name: "existing-composite",
 			schema: `
@@ -801,7 +782,7 @@ func TestWhereAttributeCompletions(t *testing.T) {
 					}
 				}
 			}`,
-			expected: []string{"createdAt", "email", "emailVerified", "externalId", "id", "issuer", "updatedAt", "user"},
+			expected: []string{"createdAt", "email", "emailVerified", "externalId", "id", "issuer", "password", "updatedAt", "user"},
 		},
 
 		{
@@ -997,41 +978,29 @@ func TestWhereAttributeCompletions(t *testing.T) {
 func TestSetAttributeCompletions(t *testing.T) {
 	cases := []testCase{
 		{
-			name: "set-expression-nested",
+			name: "set-expression",
 			schema: `
 			model User {
 				fields {
 					identity Identity
-					name Text
-				}
-
-				actions {
-					create createUser() with (name) {
-						@set(user.identity = ctx.identity)
-						@permission(expression: ctx.isAuthenticated)
-					}
 				}
 			}
-
 			model Team {
 				fields {
 					name Text
 				}
 			}
-
 			model UserTeam {
 				fields {
 					user User
 					team Team
 				}
-
 				actions {
 					create createTeam() with (team.name) {
 						@set(<Cursor>)
 					}
 				}
-			}
-			`,
+			}`,
 			expected: []string{"ctx", "userTeam"},
 		},
 		{
@@ -1074,7 +1043,7 @@ func TestSetAttributeCompletions(t *testing.T) {
 					}
 				}
 			}`,
-			expected: []string{"createdAt", "email", "emailVerified", "externalId", "id", "issuer", "updatedAt", "user"},
+			expected: []string{"createdAt", "email", "emailVerified", "externalId", "id", "issuer", "password", "updatedAt", "user"},
 		},
 		{
 			name: "set-attribute-ctx-identity-user",
@@ -1112,11 +1081,11 @@ func TestSetAttributeCompletions(t *testing.T) {
 				}
 				actions {
 					list create() {
-						@set(ctx.identity.<Cursor>)
+						@set(user.owner = ctx.identity.<Cursor>)
 					}
 				}
 			}`,
-			expected: []string{"createdAt", "email", "emailVerified", "externalId", "id", "issuer", "updatedAt", "user"},
+			expected: []string{"createdAt", "email", "emailVerified", "externalId", "id", "issuer", "password", "updatedAt", "user"},
 		},
 	}