fix: labelled inputs sometimes validated against for functions (#1291)

teamkeel · Nov 9, 2023 · 7d63db1 · 7d63db1
1 parent a3406f1
commit 7d63db1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/schema/__debug_bin947378542 b/schema/__debug_bin947378542
diff --git a/schema/validation/unused_inputs.go b/schema/validation/unused_inputs.go
@@ -15,16 +15,12 @@ func UnusedInputRule(_ []*parser.AST, errs *errorhandling.ValidationErrors) Visi
 	unused := map[string]*parser.NameNode{}
 
 	return Visitor{
-		EnterModelSection: func(n *parser.ModelSectionNode) {
-			isAction = len(n.Actions) > 0
-		},
-		LeaveModelSection: func(n *parser.ModelSectionNode) {
-			isAction = false
+		EnterAction: func(n *parser.ActionNode) {
+			unused = map[string]*parser.NameNode{}
+			isAction = true
 		},
 		LeaveAction: func(n *parser.ActionNode) {
-			if !isAction {
-				return
-			}
+			isAction = false
 
 			// if the action is implemented as a function, then we don't know how the function
 			// uses the inputs (if at all), so not a validation error.
@@ -43,11 +39,9 @@ func UnusedInputRule(_ []*parser.AST, errs *errorhandling.ValidationErrors) Visi
 					),
 				)
 			}
-
-			unused = map[string]*parser.NameNode{}
 		},
 		EnterActionInput: func(n *parser.ActionInputNode) {
-			if n.Label == nil || !isAction {
+			if n.Label == nil {
 				return
 			}
 			unused[n.Label.Value] = n.Label