-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix healtcheck fail when TELEGRAM_STAT is not set #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can get rid of || exit 1
for now.
Dockerfile
Outdated
@@ -30,6 +30,6 @@ RUN addgroup -g 101 -S telegram-bot-api \ | |||
&& chmod 700 ${TELEGRAM_TEMP_DIR} | |||
USER telegram-bot-api:telegram-bot-api | |||
|
|||
HEALTHCHECK CMD curl -f http://localhost:8082/ || exit 1 | |||
HEALTHCHECK CMD nc -z localhost 8081 || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you test it without exit 1
? if that works i'll remove it [cc @MarcoBuster]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giuseppeM99, @luckydonald is right.
marco@acer-pop:~$ nc 127.0.0.1 12345
marco@acer-pop:~$ echo $?
1
I tested the netcat command like that, and it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This should close #30
plus this removes curl from the dependencies