Remove source phase resolution time negative error types #4194
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woess
reviewed
Aug 14, 2024
|
|
||
| import source from '<do not resolve>'; | ||
| import from from '<do not resolve>'; | ||
| import source from '<module source>'; |
There was a problem hiding this comment.
I think we should avoid using <module source> in non-source imports.
|
Instead of doing this, can we just remove This is to avoid having to require another flag, which may prevent some implementations from running the test. |
legendecas
force-pushed
the
module-source-specifier
branch
from
4913f78 to
3756e28
Compare
legendecas
changed the title
<module source> specifier
Updated. Thanks for suggestion, sounds like a good alternative to me. |
legendecas
force-pushed
the
module-source-specifier
branch
from
3756e28 to
978e07f
Compare
nicolo-ribaudo
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source phase import binding name tests can be tested more easily with the resolution time negative error types removed, as they are host defined errors.
Refs: #4121 (comment)