-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import tests from SpiderMonkey #4106
Conversation
Comparison of results between SpiderMonkey and V8
I've not looked at the 402 failures at all. |
79e029d
to
7279479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am definitely not reviewing the giant automated import. But the other stuff around it looks good.
This code currently prevents tests from using |var join|.
These belong to a test that is not imported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the maintainers chat, approving and merging this.
(Based on past runs, the esmeta job is likely going to time out after 6 hours, so I won't wait for that.) |
No description provided.