Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] Publish PR previews #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gibson042
Copy link

Fixes #30

  • Rename .github/workflows/deploy.yml → .github/workflows/publish-main.yml.
  • Replace .github/workflows/build.yml with .github/workflows/render-pr.yml, which uploads the result as an artifact.
  • Introduce .github/workflows/publish-pr.yml, which runs on completion of render-pr.yml and publishes into gh-pages at pr/$PR (and adds a comment with that link).
  • publish-pr.yml also adds a preview warning with code derived from ecma262 insert_snapshot_warning.js (see example at https://tc39.es/proposal-immutable-arraybuffer/pr/21/ ).
  • Once this settles, I'll open a PR to align ecma262 preview warnings as well.
Preview Warning

collapsed

expanded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: PR Preview Github Action Workflows
1 participant