Use null for computing rather than undefined
#235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with the type specified for `currentComputed()`.
littledan
approved these changes
Aug 6, 2024
|
@littledan it looks like Personally I'm very much in favor of it - i love offering the affordance to get this stuff, open the option! - but it definitely wasn't what's described in the ticket. Just want to re-share awareness that this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used
undefinedhere, and that's what's currently returned bycurrentComputed()in the Polyfill. However,nullis what is specified in the TypeScript type definition, and prevailing opinion on the Discord suggests it's a better choice thanundefinedas it clarifies intentionality better.If/once merged, we'll need to alter the polyfill and tests.