Bug 1937801 - Implement mechanism to use caches for common tools in run transforms #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
ahal/push-rwqssntoyqlt
branch
from
4e22fba to
fe7762e
Compare
ahal
added
the
BREAKING CHANGE
ahal
force-pushed
the
ahal/push-rwqssntoyqlt
branch
10 times, most recently
from
0fdd5eb to
f876c2b
Compare
ahal
force-pushed
the
ahal/push-rwqssntoyqlt
branch
from
f876c2b to
e337f3a
Compare
ahal
force-pushed
the
ahal/push-rwqssntoyqlt
branch
from
e337f3a to
af00663
Compare
Using a regex to maintain an exclude list is not a great UX and is error prone. This also forces users to be explicit with the set of caches that they want.
ahal
force-pushed
the
ahal/push-rwqssntoyqlt
branch
from
af00663 to
42632c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an overhaul of how we set up caches in the run transforms. At a high level, this is:
cache-dotcachekeyI recommend reviewing commit by commit.
Making this a draft PR for now so I have a chance to test it out with real tasks.