Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code update 20211121 #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

nikitasius
Copy link

Hi, there are some updates which i personally need for your wonderful code (thanks a lot for your implementation!):

  • added byte[] and byte[][] outputs
  • added simplfied methods w/o offet and len (when i hash whole data)
  • removed some redundant moments (like int i=0; or ((b[i+0] & 255) << 0)) changed into (b[i] & 255)), etc.

* CityHash.java
  * `cityHash64b`/`cityHash64b` returns `byte[]` data, full and simplified versions (w/o offset and len)
  * `cityHash64` simplified version w/o offset and len
* CityHashTest.java
  * Tests for `cityHash64b` and `cityHash64`
* CityHash.java
  * `cityHash128b`/`cityHash128WithSeedb` returns `byte[][]` data, full and simplified versions (w/o offset and len)
  * `cityHash128`/`cityHash128WithSeed` are simplified version w/o offset and len

* CityHashTest.java
  * Tests for `cityHash128b`,`cityHash128WithSeedb`,`cityHash128` and `cityHash128WithSeed`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant