Refactor GenericGCode, fix some bugs #177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmax
force-pushed
the
refactor-genericgcode
branch
from
52f9a4f to
1fc9026
Compare
mgmax
force-pushed
the
refactor-genericgcode
branch
from
1fc9026 to
5106508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most important bugs:
currentFocusvariable was not reset correctly, so sending the same job twice did sometimes not have the same content.applyStartPoint()was not called when saving to file, leading to inconsistent behavior when saving to file vs. sending to network, if "set start point" was used in VisiCut