-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fixed size blocks with linked list #176
Merged
jserv
merged 1 commit into
sysprog21:master
from
ChAoSUnItY:refactor/reduce-blocks-alloc
Jan 16, 2025
Merged
Replace fixed size blocks with linked list #176
jserv
merged 1 commit into
sysprog21:master
from
ChAoSUnItY:refactor/reduce-blocks-alloc
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
changed the title
Reimplement fixed size blocks array with linked list
Replace fixed size blocks with linked list
Jan 15, 2025
jserv
reviewed
Jan 15, 2025
jserv
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve git commit messages.
ChAoSUnItY
force-pushed
the
refactor/reduce-blocks-alloc
branch
2 times, most recently
from
January 16, 2025 07:42
907682e
to
4fbe2ee
Compare
jserv
reviewed
Jan 16, 2025
jserv
reviewed
Jan 16, 2025
jserv
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refine the git commit messages:
This adjustment enables compilation to use as much blocks as the compilation needs instead of allocating huge fixed-size array for block structures to store, not only saves memory when compiling small programs, but also prevents potential insufficient allocation issues in the future work. This improves significantly while compiling small programs. For example, compiling "tests/hello.c" previously takes roughly 224.528 mb, while this patch reduces to roughly 51.852 mb.
ChAoSUnItY
force-pushed
the
refactor/reduce-blocks-alloc
branch
from
January 16, 2025 15:10
4fbe2ee
to
e22f595
Compare
Thank @ChAoSUnItY for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts size of blocks array based on demand instead of using a constant, to prevent potential insufficient allocation issues in the future work, also reduces memory usage when compiling small programs.
I use
/usr/bin/time -v ./out/shecc tests/hello.c
to benchmark the usage of memory:Before:
After: