This repository has been archived by the owner on May 7, 2023. It is now read-only.
use null safe versions of dependencies #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For GeoJson : https://github.com/it-sam/geojson |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter_map is preparing a null safe version: fleaflet/flutter_map#870
It can already be used: fleaflet/flutter_map#870
I am already using the null safe version. Unfortunately map_controller is not null safe yet. And it depends on geopoint.
So this pull request aims to make geopoint null safe. To then enable map_controller to become null safe.
Warning: I am a flutter noob (JavaScript dev). And could not test this as my library that depends on it (map_controller) can not be altered to use a git dependency (or so flutter tells me). So feel free to change this pull request as much as you like. Or simply close it and solve it better.
Relates to #6 and encompasses #5.
More changes are needed to make the code itself null safe: https://dart.dev/null-safety/migration-guide#step2-migrate. Unfortunately I don't feel up to knowing enough about this library's code to do that.