Accessibility audit fixes #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@stolinski These are all just HTML edits, but can you give it a quick scan and merge? |
Bundle ReportChanges will increase total bundle size by 7.86kB ⬆️
|
stolinski
approved these changes
Sep 4, 2024
|
Hell yeah. |
github-actions bot
added a commit
that referenced
this pull request
Sep 4, 2024
* Upgrade Sentry packages * adds skip to main content link * fix: The link text for the logo link can be more descriptive * Adds aria label to large number to give better context to screen readers * adds description to search button * Adds aria label to share button * Adds title text to share button * Remove redundant alt text from figure * fixes mislabled aria-labeledby header * changes share heading dialog to h2, styled as h3 * adds close label to share dialog * fixes inert toast messages * switch host images to presentation only * adds labels to player action buttons 2.1.116
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most issues brought up in #1808
The only thing not fixed is the markdown headings - might need to think on how to do that.
This also includes an upgrade of the sentry SDKs as I couldn't get the site to run locally without upgrading.