Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection upload fixes #9

Merged
merged 1 commit into from
Oct 13, 2014
Merged

Collection upload fixes #9

merged 1 commit into from
Oct 13, 2014

Conversation

ioleo
Copy link
Member

@ioleo ioleo commented Oct 13, 2014

This PR introduces various collection upload fixes:

  • change "Upload" button type from "submit" to "button" (this bug caused the whole form to be submitted)
  • change icons to FontAwesome
  • replace non-working progress bar with a spinning cog icon indicating that upload is in progress
  • render editable fields for uploaded files (async) and capture the submitted data in the eventlistener to bind it to the object being created
  • add sanity check in ReorderCollectionListener to prevent PHP warning messages
  • add displayDownloadButton option, to further customize the widget behaviour
  • remove the "disabled" class to make the "delete" checkbox clickable again

@ioleo
Copy link
Member Author

ioleo commented Oct 13, 2014

This PR fixes #5

ioleo pushed a commit that referenced this pull request Oct 13, 2014
@loostro
Merge pull request #9 from symfony2admingenerator/develop
f857969 
Collection upload fixes
@ioleo ioleo merged commit f857969 into master Oct 13, 2014
@ioleo ioleo deleted the develop branch November 11, 2014 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioleo @loostro