-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #LGVISIUM-92: Add GitHub actions and push Docker images to GHCR #93
Close #LGVISIUM-92: Add GitHub actions and push Docker images to GHCR #93
Conversation
@stijnvermeeren-swisstopo I do believe that we made all the necessary initial checks with Oliver. There are just two open questions for you regarding how to reach a maintainer in case of problems. |
--method PATCH \ | ||
--header "Accept: application/vnd.github+json" \ | ||
/repos/${GITHUB_REPOSITORY}/releases/${RELEASE_ID} \ | ||
-f body="$(./get-changelog.sh)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will discuss with Oliver in detail how this script works. Even without the script, the pipeline was running which is surprizing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that without the script, it just skips the automatic updating of the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would have expected the pipeline to crash, but the behavior you described is the one observed.
This PR makes it possible to generate the Docker Container of the Borehole data extraction API in a similar way to https://github.com/swisstopo/swissgeol-boreholes-suite.
Upon merging to the main, a GitHub Actions creates automatically creates a new container with the latest version of the code and an
edge
tag. The container is then stored in the GitHub Container Registry.