-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #LGVISIUM-77: Wrong elevation value selected within bounding box #91
Close #LGVISIUM-77: Wrong elevation value selected within bounding box #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment to https://jira.swisstopo.ch/browse/LGVISIUM-77 to describe the decision to only sort by vertical distance, as this already improves the results sufficiently, and that we therefore did not yet test the idea of looking horizontally and vertically (but not diagonally) from the key line.
@stijnvermeeren-swisstopo I added a description on the rational of only sorting vertically to Jira and how this could be improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the comment on the Jira ticket. LGTM!
Started to sort vertically the different text lines matched around the matched keyword. By sorting, it was possible to test which was the closest to the keyword first and thus reduce the number of false positives or errors in elevation and groundwater detection.
@stijnvermeeren-swisstopo In today's stand-up, we discussed the possibility of vertically and horizontally sorting the text. Currently, all the issues I found are solved with this code in combination with the improvements you made in the OCR processing. However, if you wish, I can also try this technique.
The metrics from the
main
branch are in silent-quail-641, and the performance of this branch isambitious-mule-939