Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #LGVISIUM-74: Update the API based on the new s3 specs & feedback #79

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

dcleres
Copy link
Contributor

@dcleres dcleres commented Sep 11, 2024

Update the API based on the new S3 specs & feedback borehole application. The API now saves the single PDF pages as PNG in the dataextraction/ path on S3.

Furthermore, I made one small change in the prototype of a function as the parameter naming was outdated.

Copy link

github-actions bot commented Sep 11, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/stratigraphy
   __init__.py8188%11
   extract.py1881880%3–491
   get_files.py19190%3–47
   line_detection.py26260%3–76
   main.py1191190%3–274
src/stratigraphy/coordinates
   coordinate_extraction.py108595%30, 64, 83–84, 96
src/stratigraphy/data_extractor
   data_extractor.py50394%32, 62, 98
src/stratigraphy/util
   boundarydepthcolumnvalidator.py412051%47, 57, 60, 81–84, 110–128, 140–149
   dataclasses.py32391%37–39
   depthcolumn.py1946467%26, 30, 51, 57, 60–61, 85, 88, 95, 102, 110–111, 121, 138–154, 192, 229, 248–256, 267, 272, 279, 310, 315–322, 337–338, 381–423
   depthcolumnentry.py28679%17, 21, 36, 39, 56, 65
   description_block_splitter.py70297%25, 140
   draw.py1171170%3–349
   duplicate_detection.py51510%3–146
   extract_text.py31487%20, 36, 57–58
   find_depth_columns.py91693%42–43, 73, 86, 180–181
   find_description.py632856%27–35, 50–63, 79–95, 172–175
   geometric_line_utilities.py86298%82, 132
   interval.py1045547%25–28, 33–36, 42, 48, 52, 62–64, 101–147, 168, 174–190
   language_detection.py18180%3–45
   layer_identifier_column.py91910%3–234
   line.py51492%26, 51, 61, 111
   linesquadtree.py46198%76
   plot_utils.py43430%3–120
   predictions.py1541540%3–364
   textblock.py80989%29, 57, 65, 90, 102, 125, 146, 155, 184
   util.py391756%22, 40–47, 61–63, 87–88, 100–104
TOTAL1948105646% 

Tests Skipped Failures Errors Time
79 0 💤 0 ❌ 0 🔥 5.394s ⏱️

@dcleres dcleres merged commit b7d34ce into main Sep 11, 2024
3 checks passed
@dcleres dcleres deleted the LGVISIUM-74-Update-the-API-based-on-Feedback branch September 13, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants