Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize language in language detection and coordinate extraction. #56

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

redur
Copy link
Contributor

@redur redur commented Jun 3, 2024

PR to parametrize language in the config files.

I believe there should be nothing remaining in the code that specifies a language now. The language is completely abstracted in the matching_params.yml config file.

@redur redur self-assigned this Jun 3, 2024
@redur redur force-pushed the feat/parametrize_languages branch from 6ee6a30 to 5683f92 Compare June 3, 2024 06:31
Copy link

github-actions bot commented Jun 3, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/stratigraphy
   __init__.py8188%11
   extract.py2102100%3–506
   get_files.py21210%3–48
   line_detection.py26260%3–76
   main.py91910%3–234
src/stratigraphy/util
   coordinate_extraction.py1172083%27, 47, 51, 55, 59–67, 88, 164, 184, 273, 276–277, 281, 293
   dataclasses.py32391%37–39
   depthcolumn.py2086768%26, 30, 51, 57, 60–61, 85, 88, 95, 102, 110–111, 121, 138–154, 199, 238, 254–262, 274, 279, 286, 313, 323, 352, 373, 376–387, 402–403, 448–490
   depthcolumnentry.py20480%12, 15, 27, 34
   description_block_splitter.py70297%24, 139
   draw.py73730%3–225
   duplicate_detection.py51510%3–146
   find_depth_columns.py89693%41–42, 70, 82, 175–176
   find_description.py632856%27–35, 50–63, 79–95, 172–175
   geometric_line_utilities.py86298%82, 132
   interval.py1075251%25–28, 32–35, 40, 45, 48, 100–146, 167, 172–188
   language_detection.py18180%3–45
   layer_identifier_column.py91910%3–227
   line.py492647%25, 42, 51, 65–95, 98
   linesquadtree.py46198%76
   plot_utils.py43430%3–120
   predictions.py1861860%3–386
   textblock.py74889%27, 51, 63, 75, 98, 119, 127, 155
   util.py402245%15–18, 22, 26, 40–47, 61–63, 87–88, 100–105
TOTAL1819105242% 

Tests Skipped Failures Errors Time
58 0 💤 0 ❌ 0 🔥 0.625s ⏱️

@redur
Copy link
Contributor Author

redur commented Jun 3, 2024

#53

@redur redur merged commit 6dedc85 into main Jun 3, 2024
3 checks passed
@redur redur deleted the feat/parametrize_languages branch June 3, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants