-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/remove duplicated dependency declaration #54
Conversation
Note: Currently only local installation using |
df3ace9
to
edb6832
Compare
] | ||
|
||
[project.optional-dependencies] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the optional dependencies, we don't need to be that strict. I.e. we don't need to weaken the version as this is very much related to development and not for production purposes.
Since we look at the pyproject.toml file in this PR, I open the discussion about the package name. Further, do we plan to publish the package on pypi at some point? |
|
|
Rename package. Rename command to extract information from borehole profiles. Some fixes in the dependency declaration.
Comments are addressed. Let me know if it's all good now. |
Follow up ticket in Jira is created. |
All dependencies are now directly managed in the pyproject.toml file.
Please consider the following:
Since we're developing a python package that is intended to use in combination with other python code and packages, we should keep the dependency restrictions as weak as possible. On the production side on the other hand, we want to fix all dependencies to fix the behavior of the production service.
We now made the shift from a fixed environment to declaring dependencies for the swissgeol-boreholes-dataextraction package. Therefore I tried to lift as many restrictions as possible. I believe we could further lift restrictions. I.e. do we really need python>3.10?
As we're the only users for now it is not an issue, but something to consider in the future. We also need to be careful, every time we notice some dependency issues, we have to adapt our restrictions in pyproject.toml.
Another note: I kept the restrictions for the dev dependencies rather fixed (I don't call them dev any more, but rather split them into test,lint,experiment_tracking & visualize. I haven't wrapped my head around if it really makes sense to have that many.
Test can be used for the testing CI.
Lint can be used for the lint CI.
Experiment tracking should be installed for local development (alongside with test and lint).
Visualize was something we used in a notebook, there's no need for a general user to install visualize. We could even think of removing this extra dependency alltogether.