Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only check for layer identifiers in the first word of each line #47

Conversation

stijnvermeeren-swisstopo
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented May 22, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/stratigraphy
   __init__.py8188%11
   extract.py2112110%3–507
   get_files.py21210%3–48
   line_detection.py26260%3–76
   main.py91910%3–232
src/stratigraphy/util
   coordinate_extraction.py1283176%30, 50, 54, 58–66, 143, 163, 235–241, 250–252, 268–282
   dataclasses.py32391%37–39
   depthcolumn.py2066767%26, 30, 51, 57, 60–61, 85, 88, 95, 102, 110–111, 121, 138–154, 199, 238, 254–262, 274, 279, 286, 310, 314, 343, 364, 367–378, 393–394, 439–481
   depthcolumnentry.py20480%12, 15, 27, 34
   description_block_splitter.py70297%24, 139
   draw.py73730%3–225
   duplicate_detection.py32320%3–81
   find_depth_columns.py89693%39–40, 68, 80, 173–174
   find_description.py632856%27–35, 50–63, 79–95, 172–175
   geometric_line_utilities.py87298%83, 133
   interval.py1075251%25–28, 32–35, 40, 45, 48, 100–146, 167, 172–188
   language_detection.py18180%3–43
   layer_identifier_column.py91910%3–227
   line.py492647%25, 42, 51, 65–95, 98
   linesquadtree.py46198%76
   plot_utils.py44440%3–121
   predictions.py1871870%3–385
   textblock.py74889%27, 51, 63, 75, 98, 119, 127, 155
   util.py402245%15–18, 22, 26, 40–47, 61–63, 87–88, 100–105
TOTAL1813104742% 

Tests Skipped Failures Errors Time
58 0 💤 0 ❌ 0 🔥 0.609s ⏱️

@stijnvermeeren-swisstopo stijnvermeeren-swisstopo marked this pull request as ready for review May 22, 2024 15:15
@redur
Copy link
Contributor

redur commented May 22, 2024

I can see that this adds value, but unfortunately it is not fault proof either.

See e.g.:

  • 5793.pdf (IdentifierColumn is in the description text).
  • 7317.pdf (here there are only few entries not recognized)

I still propose that we merge your suggestion, as it seems to make the code more robust overall.

5793
image

7317
image

@stijnvermeeren-swisstopo
Copy link
Contributor Author

Thanks @redur for these good observations! This seems to be a new layout type from a company "SOLAB F. Perrin S.A.", that is somewhere in between the Deriaz layouts and the "LayerDepthColumn" implementation. I've created a follow-up ticket for this: https://jira.swisstopo.ch/browse/LGVISIUM-40

@stijnvermeeren-swisstopo stijnvermeeren-swisstopo merged commit 9bae4a1 into feat/extend_geneva_layouts May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants