LGVISIUM-80: review proposal Stijn

[stijnvermeeren-swisstopo]

A generic FeatureOnPage class that can be reused for groundwater, elevation, coordinates... instead of requiring separate classes GroundwaterOnPage, ElevationOnPage, CoordinatesOnPage etc.

Upgrade to Python 3.11 in order to be able to use from typing import Self.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/stratigraphy
__init__.py	8	1	88%	11
extract.py	198	198	0%	3–499
get_files.py	19	19	0%	3–47
main.py	117	117	0%	3–314
src/stratigraphy/benchmark
ground_truth.py	21	1	95%	47
metrics.py	59	43	27%	18, 22–25, 29–32, 36–39, 46–49, 53–54, 58, 65–72, 76–89, 94–133
src/stratigraphy/data_extractor
data_extractor.py	75	6	92%	30, 39, 52, 92, 129, 174
src/stratigraphy/depthcolumn
boundarydepthcolumnvalidator.py	41	20	51%	47, 57, 60, 81–84, 110–128, 140–149
depthcolumn.py	227	82	64%	28, 33, 65, 82, 87, 93, 109–117, 138, 146, 154–155, 171–173, 188, 195, 208–209, 226, 254–273, 311, 319–320, 336–338, 383, 402–410, 421, 426, 433, 464, 469–476, 491–492, 534–575
depthcolumnentry.py	36	10	72%	17, 21, 37, 52, 55, 72, 81, 98–100
find_depth_columns.py	106	19	82%	42–43, 73, 86, 180–181, 225–245
src/stratigraphy/depths_materials_column_pairs
depths_materials_column_pairs.py	19	7	63%	23, 34, 55–60
src/stratigraphy/evaluation
evaluation_dataclasses.py	49	16	67%	24, 33, 42–44, 52, 71–74, 90, 104, 125–131, 147
groundwater_evaluator.py	48	27	44%	27, 35, 39–42, 46–49, 63–64, 72–128
metadata_evaluator.py	38	14	63%	53–72, 95–102
utility.py	34	24	29%	30–34, 48–57, 72–93
src/stratigraphy/groundwater
groundwater_extraction.py	156	103	34%	44, 52, 66–67, 79, 94, 127–132, 140, 167–171, 186–206, 217–306, 322–354
utility.py	39	33	15%	10–17, 30–47, 59–73, 88–102
src/stratigraphy/layer
layer.py	58	20	66%	30, 40, 58–95, 107–108, 121, 139
layer_identifier_column.py	79	55	30%	16–17, 20, 28, 43, 52, 61, 69–73, 81, 89, 106–111, 123, 136, 149–150, 169–172, 195–205, 219–246
src/stratigraphy/lines
geometric_line_utilities.py	86	2	98%	81, 131
line.py	51	4	92%	25, 50, 60, 110
linesquadtree.py	46	1	98%	75
src/stratigraphy/metadata
coordinate_extraction.py	110	5	95%	30, 68, 98–99, 111
elevation_extraction.py	90	60	33%	34–39, 47, 55, 63, 79–87, 124–138, 150–153, 165–197, 212–220, 228–232
language_detection.py	18	13	28%	17–23, 37–45
metadata.py	66	24	64%	27, 83, 101–127, 146–155, 195–198, 206
src/stratigraphy/text
description_block_splitter.py	70	2	97%	24, 139
extract_text.py	29	3	90%	19, 53–54
find_description.py	64	28	56%	27–35, 50–63, 79–95, 172–175
textblock.py	80	9	89%	28, 56, 64, 89, 101, 124, 145, 154, 183
src/stratigraphy/util
dataclasses.py	32	3	91%	37–39
interval.py	104	55	47%	29–32, 37–40, 46, 52, 56, 66–68, 107–153, 174, 180–196
predictions.py	146	88	40%	77, 85–93, 130, 153–179, 214–243, 257–291, 303–308, 325–340, 358–375
util.py	34	13	62%	41, 69–76, 90–92, 116–117
TOTAL	2459	1125	54%

Tests	Skipped	Failures	Errors	Time
86	0 💤	0 ❌	0 🔥	6.627s ⏱️

[dcleres]

@stijnvermeeren-swisstopo thank you for the code suggestion. I think it was a good idea to update the python version to get access to these features. I made a few small changes in code and in the docstrings as not all of them were up to date. I am happy to merge.