Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Linux testing action for RxSwift #951

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

clackary
Copy link
Contributor

Pull Request Description

Adds an action to test RxSwift on Linux.

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • MIT
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

@clackary
Copy link
Contributor Author

This still needs an xfail, but I wanted to verify it catches the failure.

Is there a way to ask swift-ci for a Linux test?

@shahmishal
Copy link
Member

@swift-ci test

@shahmishal
Copy link
Member

it will only verify macOS. However, the post merge testing will verify Linux.

@clackary can you verify this project builds with nightly main and release/6.0 docker images?

@clackary
Copy link
Contributor Author

I have verified locally that both main and release/6.0 xfail on Linux due to swiftlang/swift#76039, so I expect that config to be fine.

root@94090f859dba:/project/swift-source-compat-suite# ./runner.py --swiftc /home/dev-toolchain/swift-DEVELOPMENT-SNAPSHOT-2024-09-18-a-ubuntu22.04-aarch64/usr/bin/swiftc --projects projects.json --include-actions 'action.startswith("BuildSwiftPackage")' --swift-branch main --include-repos 'path == "RxSwift"'
Building 1 projects across 4 parallel processes

XFAIL: https://github.com/swiftlang/swift/issues/76039, RxSwift, 5.0, b4307b, Swift Package
========================================
XFailures:
  XFAIL: https://github.com/swiftlang/swift/issues/76039, RxSwift, 5.0, b4307b, Swift Package
========================================
Action Summary:
     Passed: 0
     Failed: 0
    XFailed: 1
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: XFAIL
========================================


root@94090f859dba:/project/swift-source-compat-suite# ./runner.py --swiftc /home/dev-toolchain/swift-6.0-RELEASE-ubuntu22.04-aarch64/usr/bin/swiftc --projects projects.json --include-actions 'action.startswith("BuildSwiftPackage")' --swift-branch main --include-repos 'path == "RxSwift"'
Building 1 projects across 4 parallel processes

XFAIL: https://github.com/swiftlang/swift/issues/76039, RxSwift, 5.0, b4307b, Swift Package
========================================
XFailures:
  XFAIL: https://github.com/swiftlang/swift/issues/76039, RxSwift, 5.0, b4307b, Swift Package
========================================
Action Summary:
     Passed: 0
     Failed: 0
    XFailed: 1
    UPassed: 0
      Total: 1
========================================
Repository Summary:
      Total: 1
========================================
Result: XFAIL
========================================

As for macOS, it looks like RxSwift is passing on the main job and the release/6.0 job.

@shahmishal
Copy link
Member

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants