Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _Unicode and script data #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove _Unicode and script data #255

wants to merge 2 commits into from

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Apr 6, 2022

No description provided.

@Azoy Azoy requested review from milseman and rxwei April 6, 2022 21:35
@Azoy Azoy mentioned this pull request Apr 6, 2022
Merged
@Azoy Azoy requested a review from lorentey April 6, 2022 21:36
@Azoy
Copy link
Contributor Author

Azoy commented Apr 18, 2022

@swift-ci please test

@milseman
Copy link
Member

ping? Was this done or does this need to be closed?

@Azoy
Copy link
Contributor Author

Azoy commented Apr 25, 2022

@swift-ci please test

1 similar comment
@Azoy
Copy link
Contributor Author

Azoy commented Apr 26, 2022

@swift-ci please test

@milseman
Copy link
Member 

\\p{scx=Gujr} in ꠹")/Users/ec2-user/jenkins/workspace/pr-swift-experimental-string-processing-macos/branch-main/swift-experimental-string-processing/Tests/RegexTests/MatchTests.swift:742: error: -[RegexTests.RegexTests testCharacterProperties] : failed - MatchError(message: "match not found for \\p{Gujr} in ꠹")Test Case '-[RegexTests.RegexTests testCharacterProperties]' failed (0.036 seconds).Test Suite 'RegexTests' failed at 2022-04-26 22:36:22.851.

@Azoy
Copy link
Contributor Author

Azoy commented May 19, 2022

This PR is blocked until CI has a version of Xcode that includes this SPI symbol from the standard library on macOS.

@Azoy Azoy force-pushed the remove-scripts branch 2 times, most recently from 3f704fe to 489613e Compare June 2, 2022 16:39
@Azoy
Copy link
Contributor Author

Azoy commented Jun 2, 2022

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Jun 22, 2022

@swift-ci please test macOS

2 similar comments
@Azoy
Copy link
Contributor Author

Azoy commented Jun 24, 2022

@swift-ci please test macOS

@Azoy
Copy link
Contributor Author

Azoy commented Jun 27, 2022

@swift-ci please test macOS

@Azoy
Copy link
Contributor Author

Azoy commented Jun 27, 2022

@swift-ci please test Linux

@Azoy
Copy link
Contributor Author

Azoy commented Jun 27, 2022

@swift-ci please test macOS

@Azoy Azoy force-pushed the remove-scripts branch from 2dafb5e to 73a58f8 Compare June 28, 2022 14:42
@Azoy
Copy link
Contributor Author

Azoy commented Jun 28, 2022

@swift-ci please test macOS

@Azoy Azoy force-pushed the remove-scripts branch from 73a58f8 to c8ac780 Compare June 28, 2022 15:00
@Azoy
Copy link
Contributor Author

Azoy commented Jun 28, 2022

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

@milseman milseman Awaiting requested review from milseman

@lorentey lorentey Awaiting requested review from lorentey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Azoy @milseman @lorentey @rxwei