Consistently use JSON when encoding output file maps #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
artemcm
approved these changes
Jan 13, 2025
|
A heads up this PR is formatted with 4 spaces instead of 2 |
CodaFi
reviewed
Jan 13, 2025
| } | ||
| } | ||
|
|
||
| private func quoteAndEscape(path: VirtualPath) -> String { |
There was a problem hiding this comment.
Do we actually have tests that exercise the quoting and escaping this is doing?
There was a problem hiding this comment.
I added a basic unit test for this since existing coverage wasn't great. Also ran this through source compatibility testing and the results look good there so far
CodaFi
approved these changes
Jan 13, 2025
owenv
force-pushed
the
ovoorhees/ofm-json
branch
2 times, most recently
from
a895daa to
8e8af58
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
owenv
force-pushed
the
ovoorhees/ofm-json
branch
from
8e8af58 to
c89a585
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the encoding of output file maps and remove a yams dependency we don't need in this part of the driver