libclang_rt.profile*.a search path should use osNameUnversioned #1773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms where the triple includes the os version, in this case
x86_64-unknown-freebsd14.2
,the swift-driver is trying to link against various clang rt libraries in
clang/lib/freebsd14.2
, but the actualclang convention is to have the libraries installed in
clang/lib/freebsd
instead, see clang/lib/Driver/ToolChain.cpp#L686.Although the right solution is probably to implement
getOSLibName
inswift-driver
; we can just useosNameUnversioned
for now as the only special case wheregetOSLibName != osNameUnversioned
is for
Solaris
, which is not yet supported.