Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libclang_rt.profile*.a search path should use osNameUnversioned #1773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michael-yuji
Copy link

On platforms where the triple includes the os version, in this case x86_64-unknown-freebsd14.2,
the swift-driver is trying to link against various clang rt libraries in clang/lib/freebsd14.2, but the actual
clang convention is to have the libraries installed in clang/lib/freebsd instead, see clang/lib/Driver/ToolChain.cpp#L686.

Although the right solution is probably to implement getOSLibName in swift-driver; we can just use
osNameUnversioned for now as the only special case where getOSLibName != osNameUnversioned
is for Solaris, which is not yet supported.

@michael-yuji
Copy link
Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant