Driver: simplify `Driver.computeSDKPath(_:compilerMode:toolchain:targ… #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etTriple:fileSystem:iagnosticsEngine:env:)` Simplify the logic in this method to help reduce some of the dependency on the `FileSystem` type from tools-support-core. The incidental benefit here is to reduce the dependency on `AbsolutePath` and `RelativePath`. The semantic changes incurred by this change is that the `-sdk` parameter for the frontend is now always converted to an absolute path from the relative path.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etTriple:fileSystem:iagnosticsEngine:env:)`
Simplify the logic in this method to help reduce some of the dependency on the
FileSystemtype from tools-support-core. The incidental benefit here is to reduce the dependency onAbsolutePathandRelativePath.The semantic changes incurred by this change is that the
-sdkparameter for the frontend is now always converted to an absolute path from the relative path.