Emit supplemental outputs for the target variant #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have no actual impact on compilation. The idea is that we are grouping the supplementary outputs that are specific to a given target. This will allow us to store two of them, one for the target and one for the target-variant. The end goal being that we can emit the target variant interface bits in the same driver invocation that generates the zippered object files.
This patch wires up emitting the interface information for the target variant in the same swiftc invocation that emits the zippered object file.
This patch adds the api description to the set of supplemental outputs emitted for both the target and target variant.
This adds flags for setting the variant module doc path, source info path, api descriptor path, module interface path, private interface path, and package interface path.
|
@swift-ci please test |
Now teaching the compiler to emit the ABI JSON file for the target variant module.
etcwilde
force-pushed
the
ewilde/target-variant-modules
branch
from
ef97232 to
b3c8853
Compare
|
swiftlang/swift#78336 |
owenv
approved these changes
Jan 2, 2025
artemcm
approved these changes
Jan 7, 2025
I did consider it. My reasons for not doing that was 1, size of the patch, and 2, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches the driver how to emit the supplementary outputs for a module build for the target-variant.
These supplementary outputs are:
This means that the driver can emit all of the relevant outputs for a build in a single invocation without needing to be called twice with the same arguments, with one to emit the zippered object and target supplemental outputs, and again for the target-variant outputs.
Patch to add new flags: swiftlang/swift#78336
rdar://141582282