[core] Remove platform dance in Package.swift #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsto
approved these changes
Oct 9, 2024
sebsto
requested changes
Oct 9, 2024
| let package = Package( | ||
| name: "swift-aws-lambda-runtime", | ||
| platforms: platforms, | ||
| platforms: [.macOS(.v15)], |
There was a problem hiding this comment.
This breaks the Swift 6 nightly and swift 6 language mode CI actions
/__w/swift-aws-lambda-runtime/swift-aws-lambda-runtime/Package.swift:7:25: error: reference to member 'v15' cannot be resolved without a contextual type
5 | let package = Package(
6 | name: "swift-aws-lambda-runtime",
7 | platforms: [.macOS(.v15)],
| `- error: reference to member 'v15' cannot be resolved without a contextual type
8 | products: [
9 | // this library exports `AWSLambdaRuntimeCore` and adds Foundation convenience methods
|
@fabianfett can you cross reference the issue you opened (or will open) on the SwiftPM project ? |
sebsto
changed the title
|
This change no longer breaks the CI, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.