perf(es/codegen): Remove needless string comparison #9941
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This shows up in the profiling result, so I made it explicit about whether we should commit the pending semicolon or drop it. I think it showed up in the profiling result because I used
&dyn
, but using&dyn
is a useful technique for reducing the binary size.Related issue:
swc_ecma_codegen
should invokecommit_pending_semi
explicitly #9937