Skip to content

Commit

Permalink
Accessibility: improve the color contrast in the Edit Comment "Status…
Browse files Browse the repository at this point in the history
…" box.

The current orange and red used for the radio button labels in the Edit Comment
"Status" box don't have a sufficient color contrast ratio with the background.
Removing the colors improves accessibility and consistency.

See #35659, #35622.
Fixes #36967.
Built from https://develop.svn.wordpress.org/trunk@37611


git-svn-id: http://core.svn.wordpress.org/trunk@37579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
  • Loading branch information
afercia committed Jun 1, 2016
1 parent ccf2ee5 commit 4fd6311
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 32 deletions.
13 changes: 0 additions & 13 deletions wp-admin/css/edit-rtl.css
Original file line number Diff line number Diff line change
Expand Up @@ -634,19 +634,6 @@ span.wp-media-buttons-icon:before {
max-width: 100%;
}

#poststuff .inside label.spam,
#poststuff .inside label.deleted {
color: red;
}

#poststuff .inside label.waiting {
color: orange;
}

#poststuff .inside label.approved {
color: green;
}

.ie8 #poststuff .inside #parent_id,
.ie8 #poststuff .inside #page_template {
width: 250px;
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/edit-rtl.min.css

Large diffs are not rendered by default.

13 changes: 0 additions & 13 deletions wp-admin/css/edit.css
Original file line number Diff line number Diff line change
Expand Up @@ -634,19 +634,6 @@ span.wp-media-buttons-icon:before {
max-width: 100%;
}

#poststuff .inside label.spam,
#poststuff .inside label.deleted {
color: red;
}

#poststuff .inside label.waiting {
color: orange;
}

#poststuff .inside label.approved {
color: green;
}

.ie8 #poststuff .inside #parent_id,
.ie8 #poststuff .inside #page_template {
width: 250px;
Expand Down
2 changes: 1 addition & 1 deletion wp-admin/css/edit.min.css

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions wp-admin/edit-form-comment.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@

<fieldset class="misc-pub-section misc-pub-comment-status" id="comment-status-radio">
<legend class="screen-reader-text"><?php _e( 'Comment status' ); ?></legend>
<label class="approved"><input type="radio"<?php checked( $comment->comment_approved, '1' ); ?> name="comment_status" value="1" /><?php _ex( 'Approved', 'comment status' ); ?></label><br />
<label class="waiting"><input type="radio"<?php checked( $comment->comment_approved, '0' ); ?> name="comment_status" value="0" /><?php _ex( 'Pending', 'comment status' ); ?></label><br />
<label class="spam"><input type="radio"<?php checked( $comment->comment_approved, 'spam' ); ?> name="comment_status" value="spam" /><?php _ex( 'Spam', 'comment status' ); ?></label>
<label><input type="radio"<?php checked( $comment->comment_approved, '1' ); ?> name="comment_status" value="1" /><?php _ex( 'Approved', 'comment status' ); ?></label><br />
<label><input type="radio"<?php checked( $comment->comment_approved, '0' ); ?> name="comment_status" value="0" /><?php _ex( 'Pending', 'comment status' ); ?></label><br />
<label><input type="radio"<?php checked( $comment->comment_approved, 'spam' ); ?> name="comment_status" value="spam" /><?php _ex( 'Spam', 'comment status' ); ?></label>
</fieldset>

<div class="misc-pub-section curtime misc-pub-curtime">
Expand Down
2 changes: 1 addition & 1 deletion wp-includes/version.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*
* @global string $wp_version
*/
$wp_version = '4.6-alpha-37610';
$wp_version = '4.6-alpha-37611';

/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
Expand Down

0 comments on commit 4fd6311

Please sign in to comment.