python: Add back unused imports #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and disable unused-import warning for api/__init__.py
svix-jplatte
force-pushed
the
jplatte/py-imports
branch
from
827654b to
5496c3b
Compare
tasn
reviewed
Jan 15, 2025
svix-james
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and disable unused-import warning for
api/__init__.py.Get us back into a state where we can safely publish a release.
Note: We rely on people being able to import these. We should all unused symbols to
__all__and remove thenoqacomment down the line, for now this restores the kind of broken state we had before (better than completely broken where people have no nice import part for these things).