Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csharp: allow verification of webhook signature without the need of a WebHeaderCollection #1617

Conversation

esskar
Copy link
Contributor

@esskar esskar commented Jan 5, 2025

Provide an overload to the Webhook.Verify function to except an Func<string, string> function that acts as an function provider.

Motivation

Creating an extra WebHeaderCollection everytime a webhook signature needs to get verified is unnecessary overhead for environments where the WebHeaderCollection is not part of underlying http stack; The object needs to get created just for the verification.

Solution

Allowing to pass a header provider function to avoid creating a WebHeaderCollection in asp.net core environments

See also #1616

@esskar esskar requested a review from a team as a code owner January 5, 2025 16:42
@esskar esskar changed the title charp: allow verification of webhook signature without the need of a WebHeaderCollection csharp: allow verification of webhook signature without the need of a WebHeaderCollection Jan 5, 2025
@tasn tasn merged commit bf1fc46 into svix:main Jan 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants