csharp: allow verification of webhook signature without the need of a WebHeaderCollection #1617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an overload to the
Webhook.Verify
function to except anFunc<string, string>
function that acts as an function provider.Motivation
Creating an extra
WebHeaderCollection
everytime a webhook signature needs to get verified is unnecessary overhead for environments where theWebHeaderCollection
is not part of underlying http stack; The object needs to get created just for the verification.Solution
Allowing to pass a header provider function to avoid creating a WebHeaderCollection in asp.net core environments
See also #1616