Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace redis queue impl with omniqueue #1228

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Replace redis queue impl with omniqueue #1228

merged 5 commits into from
Mar 6, 2024

Conversation

svix-jplatte
Copy link
Member

No description provided.

@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch 5 times, most recently from 2ab5553 to 0b9da7b Compare February 26, 2024 14:25
@svix-jplatte svix-jplatte mentioned this pull request Feb 26, 2024
Merged
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch from 0b9da7b to 9f931d3 Compare February 26, 2024 15:33
svix-jplatte added a commit that referenced this pull request Feb 26, 2024
@svix-jplatte
server: Print more info on failed assertions in redis module (#1234)
832ffa1 
## Motivation

In #1228, I needed some extra context on failing assertions.

## Solution

Prefer `assert_eq!`, `assert_matches!` to check expected emptiness of a
value, such that if the assertion fails, the non-empty value is printed.
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch 6 times, most recently from ef46b79 to 1b58203 Compare February 28, 2024 12:54
@svix-jplatte svix-jplatte changed the base branch from main to jplatte/redis-omniqueue-prep February 28, 2024 13:00
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch 2 times, most recently from c231957 to ed65dfe Compare February 28, 2024 15:40
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue-prep branch from cfa089a to 50eb3f9 Compare February 29, 2024 10:17
@svix-jplatte svix-jplatte mentioned this pull request Feb 29, 2024
Merged
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch 4 times, most recently from ca3b0b0 to 993439a Compare February 29, 2024 12:15
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue-prep branch from 50eb3f9 to a373bdd Compare February 29, 2024 13:00
Base automatically changed from jplatte/redis-omniqueue-prep to main February 29, 2024 17:26
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch from 993439a to 514eac4 Compare February 29, 2024 17:40
@svix-jplatte svix-jplatte changed the title WIP: Replace redis queue impl with omniqueue Replace redis queue impl with omniqueue Feb 29, 2024
@svix-jplatte svix-jplatte marked this pull request as ready for review February 29, 2024 17:40
@svix-jplatte svix-jplatte requested a review from a team as a code owner February 29, 2024 17:40
@svix-jplatte
Copy link
Member Author

Now with tests passing (locally)! Still want to do extra manual testing tomorrow before merging this, but otherwise it should finally be ready.

@svix-jplatte
Copy link
Member Author

svix-jplatte commented Feb 29, 2024 •
edited
Loading

And now the delay test is failing again... 😭
edit: After retrying, it's a different test 😒

@svix-jplatte svix-jplatte marked this pull request as draft February 29, 2024 18:24
@svix-jplatte svix-jplatte reopened this Mar 1, 2024
@svix-jplatte svix-jplatte marked this pull request as ready for review March 1, 2024 15:27
svix-james
svix-james previously approved these changes Mar 1, 2024
View reviewed changes
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch 2 times, most recently from 62acf9a to 2bfca25 Compare March 4, 2024 12:37
@svix-jplatte

This comment was marked as outdated.

Sign in to view
@svix-jplatte

This comment was marked as outdated.

Sign in to view
@svix-jplatte
Copy link
Member Author

svix-jplatte commented Mar 4, 2024 •
edited
Loading

Next test being a problem: test_delay. I saw it failing a few times when this PR wasn't as far along, but not very consistently. Now it's somewhat consistently and I just realized that it also takes forever (in numbers: >30.55s), apparently the recv waits for the "block time" / deadline to elapse for some reason. More investigation ahead 🥲

@svix-jplatte svix-jplatte marked this pull request as draft March 4, 2024 14:03
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch from 2bfca25 to 770664d Compare March 5, 2024 11:09
@svix-jplatte svix-jplatte mentioned this pull request Mar 5, 2024
Merged
@svix-jplatte svix-jplatte force-pushed the jplatte/redis-omniqueue branch from 770664d to 364a018 Compare March 5, 2024 15:15
@svix-jplatte
Copy link
Member Author

svix-jplatte commented Mar 5, 2024 •
edited
Loading

Daamn, tests passed the first time after rebase. So yeah, the latest problem that made tests flake was fixed in #1249! And finally, I did the local testing with old worker / new API plus the other way around, and that worked too 🎉

@svix-jplatte svix-jplatte marked this pull request as ready for review March 5, 2024 16:14
@svix-jplatte svix-jplatte requested a review from svix-james March 5, 2024 16:14
@svix-jplatte svix-jplatte merged commit bdb44ee into main Mar 6, 2024
5 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/redis-omniqueue branch March 6, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-james svix-james svix-james approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svix-jplatte @svix-james