Skip to content

Commit

Permalink
server: Use forked validator crate (#1570)
Browse files Browse the repository at this point in the history
## Motivation

The version of validator we were using depends on an old `idna`, and has
a bug where it can panic in validation.

## Solution

Because upgrading to v0.17+ is pretty involved, switch to our fork for
now which fixes the panic and upgrades dependencies but is otherwise the
same as v0.16.1.
  • Loading branch information
svix-jplatte authored Dec 17, 2024
2 parents 31aecfd + 19a656b commit ae2766b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 24 deletions.
4 changes: 0 additions & 4 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ ignore = [
"RUSTSEC-2023-0071",
# TODO: Wait for dependencies to upgrade off of proc-macro-error
"RUSTSEC-2024-0370",
# Doesn't affect us, we only use the vulnerable version through validator
# and don't use that for any sensitive auth checks.
# Details: https://github.com/svix/monorepo-private/issues/9541
"RUSTSEC-2024-0421",
]

[licenses]
Expand Down
26 changes: 7 additions & 19 deletions server/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion server/svix-server/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ opentelemetry = { version = "0.23.0", features = ["metrics"] }
opentelemetry_sdk = { version = "0.23.0", features = ["rt-tokio"] }
opentelemetry-http = "0.12.0"
opentelemetry-otlp = { version = "0.16.0", features = ["metrics"] }
validator = { version = "0.16.0", features = ["derive"] }
# Forked version of 0.16 with a small fix and dependency upgrades, since we
# haven't gotten around to doing a proper upgrade yet (0.17 is a large
# rewrite with a barely-useful changelog)
validator = { git = "https://github.com/svix/validator.git", rev = "aebdc34a4ed72524902ff6d63397b9c435b0578f", features = ["derive"] }
jwt-simple = "0.11.6"
ed25519-compact = "2.1.1"
chrono = { version="0.4.26", features = ["serde"] }
Expand Down

0 comments on commit ae2766b

Please sign in to comment.