Skip to content

Commit

Permalink
Libs: change release workflows to be triggered by release published (#…
Browse files Browse the repository at this point in the history
…1614)

We had an issue where pushing tags named for version numbers caused
unwanted side-effects.

Attempting to avoid this:
- no longer manually push tags.
- let the GitHub release automatically tag when it publishes.
- drive the other release workflows based on release: published events.

By moving the trigger off of tag push, this additionally opens the door
for situations where we need to push a tag then create a release for it
since the lib workflows won't be triggered until the release is
finalized.
  • Loading branch information
svix-onelson authored Jan 3, 2025
2 parents 0c32012 + 177951f commit 3c76055
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 26 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/csharp-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: C# Release

on:
push:
tags:
- 'v*'
release:
types: [published]

jobs:
dotnet:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/java-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Java Release

on:
push:
tags:
- 'v*'
release:
types: [published]

jobs:
dotnet:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/javascript-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
- 'openapi.json'
- 'javascript/**'
- '.github/workflows/javascript-release.yml'
tags:
- 'v*'
release:
types: [published]

jobs:
build:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/kotlin-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Kotlin Release

on:
push:
tags:
- 'v*'
release:
types: [published]

jobs:
kotlin:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/php-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: PHP Release

on:
push:
tags:
- 'v*'
release:
types: [published]

jobs:
packagist:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/python-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Python Release

on:
push:
tags:
- 'v*'
release:
types: [published]

jobs:
build:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/ruby-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Ruby Release

on:
push:
tags:
- 'v*'
release:
types: [published]

jobs:
dotnet:
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/rust-release.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Rust Release

on:
push:
tags:
- 'v*'
release:
types: [published]

env:
CARGO_TERM_COLOR: always
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/update-postman.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: Update Postman Collection

on:
push:
tags:
- 'v*'
release:
types: [published]

jobs:
postman:
Expand Down

0 comments on commit 3c76055

Please sign in to comment.