Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pulls semver-try-require functionality in & removes the dependency #939

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jun 28, 2024

Description

  • pulls in the try-import and try-require functions from semver-try-require
  • removes the semver-try-require dependency

Motivation and Context

semver-try-require is only used by dependency-cruiser. Although it might have been used by other packages it isn't. Maintaining semver-try-require as a separate package introduces overhead that isn't warranted => should simplify releasing dependency-cruiser.

As a separate action semver-try-require will be deprecated.

How Has This Been Tested?

  • green ci
  • additional unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Jun 28, 2024

Code Climate has analyzed commit 3108cdc and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

@sverweij sverweij merged commit f6b6d19 into main Jun 28, 2024
9 checks passed
@sverweij sverweij deleted the refactor/vendor-try-import branch June 28, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant