Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: makes generated .mjs schemas smaller #934

Merged
merged 4 commits into from
May 20, 2024

Conversation

sverweij
Copy link
Owner

Description

  • makes the generated (& distributed) .mjs version of the json schemas smaller
  • drive-by: removes type definitions in src (internal, not useful for api users) from distribution
  • drive-by: copy edits the default config template (making it smaller & a bit more readable in the process0).

Motivation and Context

Trying to make the distribution as small as it can be, without resorting to unreadable minified code.

How Has This Been Tested?

  • green ci

Screenshots

Differences are just a few %, but every byte helps.

After:
package size: 161.8 kB (-1.8 kB)
unpacked size: 629.1 kB (-9.4 kB)

Before:
package size: 163.6 kB
unpacked size: 638.5 kB

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented May 20, 2024

Code Climate has analyzed commit 0319b8d and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 8617939 into main May 20, 2024
9 checks passed
@sverweij sverweij deleted the chore/better-minify-schemas branch May 20, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant