Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(extract): reorganizes so it's easier to expand functionality #925

Merged
merged 5 commits into from
Mar 24, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Mar 23, 2024

Description, Motivation and Context

  • puts the various ast perusers in their own folders
  • moves the 'parse' wrappers to their respective folders
  • redistributes responsibilities between extract-depencencies module and parser specific code
  • names things slightly more standardly, so it's easier to grok what happens (i.e. use parse when parsing things over various other terminology)

Unifying the 'per-parser' interfaces makes it more easy to add a new one/ or make it a plugin mechanism if necessary. Also, by setting up the interface we can introduce a mechanism to do other things with AST's, like providing information on the barelly-ness, LoC, NoS.

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the refactor/extract-dependencies branch from f7f6a90 to c3b1a5a Compare March 24, 2024 16:14
Copy link

codeclimate bot commented Mar 24, 2024

Code Climate has analyzed commit d2cb690 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij changed the title refactor(extract): makes room for extracting other information from AST's refactor(extract): reorganizes so it's easier to expand functionality Mar 24, 2024
@sverweij sverweij merged commit b966c0a into main Mar 24, 2024
11 checks passed
@sverweij sverweij deleted the refactor/extract-dependencies branch March 24, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant