Add material property to Volume class #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Very small comments here. Thanks a ton for the contribution @paulromano!
dagmc/dagnav.py
Outdated
|
|
||
| if not existing_group: | ||
| # Create new group, add name/category tags, add entity | ||
| new_group = Group.create(self.model, name=f"mat:{name}") |
There was a problem hiding this comment.
We should probably provide a new Group ID here as well. They don't technically have an impact but it would make the new set complete.
dagmc/dagnav.py
Outdated
| @@ -238,13 +272,16 @@ def _get_triangle_sets(self): | |||
|
|
|||
| class Group(DAGSet): | |||
|
|
|||
| def __contains__(self, ent_set: DAGSet): | |||
| return any(vol.handle == ent_set.handle for vol in self.get_volumes().values()) | |||
There was a problem hiding this comment.
Love this. Really slick. :)
It should probably account for groups that hold surfaces too though, which can be stored in groups representing boundary conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new
materialproperty on theVolumeclass that gives users an easy way to change the material assigned to a volume without having to manually mess around with the associated groups.