Network not punished for illegal moves #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keesdejong
reviewed
Mar 20, 2020
keesdejong
reviewed
Mar 20, 2020
| for b,p in sym: | ||
| trainExamples.append([b, self.curPlayer, p, None]) | ||
|
|
||
| # ideally these should be combined so that getSymmetries takes valids as well |
There was a problem hiding this comment.
What is the problem of also returning the valids in the "getSymmetry" function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update has ONLY been applied to Othello's Tensorflow implementation.
Awaiting confirmation that this is correct, and I will apply to it to the rest.
This version is not compatible with previous version. None of the older saved models will run on this.