Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bug in sqlalchemy reconnect #2719

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix the frontend rendering issue related to choices when it is set to /describe_tables.
- Fix the error when using batch apply with dataset.
- Fix the bug of mismatched data types in the diff within the update mechanism.
- Fix a small bug in sqlachmey reconnect

## [0.4.0](https://github.com/superduper-io/superduper/compare/0.4.0...0.3.0]) (2024-Nov-02)

Expand Down
2 changes: 1 addition & 1 deletion plugins/sqlalchemy/superduper_sqlalchemy/metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def commit(self):

def reconnect(self):
"""Reconnect to sqlalchmey metadatastore."""
sql_conn = create_engine(self.uri)
sql_conn, name = self.connection_callback()
self.conn = sql_conn

# TODO: is it required to init after
Expand Down
Loading