Refactor/2479/simplify databackend contract #2710
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
superduper.backends.base.query.Query
superduper_<impl>.Databackend
t.insert(...)
instead oft.insert().execute()
since we don't need to serialize insertionst.update
,t.delete
deprecatedt.filter(...).select(...).outputs(...)
, ort.like().(...)
ort.(...).like()
t.get()
to get one data point (eager)t.ids()
to get the ids (eager)t.subset(ids)
to subset a queryt.limit(n, offset=m)
to get a chunk of data.execute()
no longer returns a cursor, instead a simple listt.column == x
, replace witht['column'] == x
q.dict()['documents']